linux-kernel - Re: [PATCH v2 12/12] media: atomisp: Fix LOGICAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Dec 2020 17:16:44 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     David Laight <David.Laight@...LAB.COM>
Cc:     "'Philipp Gerlesberger'" <Philipp.Gerlesberger@....de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...cs.fau.de" <linux-kernel@...cs.fau.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "ij72uhux@...d.informatik.uni-erlangen.de" 
        <ij72uhux@...d.informatik.uni-erlangen.de>,
        "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>
Subject: Re: [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS

On Mon, Dec 14, 2020 at 11:53:04AM +0000, David Laight wrote:
> From: Philipp Gerlesberger
> > Sent: 14 December 2020 11:02
> >
> > Logical continuations should be on the previous line
> > 
> > Co-developed-by: Andrey Khlopkov <ij72uhux@...d.informatik.uni-erlangen.de>
> > Signed-off-by: Andrey Khlopkov <ij72uhux@...d.informatik.uni-erlangen.de>
> > Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@....de>
> > ---
> >  drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c
> > b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c
> > index 2f1c2df59f71..7d44070c7114 100644
> > --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c
> > +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c
> > @@ -24,8 +24,8 @@
> >   *****************************************************************************/
> >  int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc)
> >  {
> > -	if (NULL == qhandle || NULL == desc
> > -	    || NULL == desc->cb_elems || NULL == desc->cb_desc) {
> > +	if (NULL == qhandle || NULL == desc ||
> > +	    NULL == desc->cb_elems || NULL == desc->cb_desc) {
> >  		/* Invalid parameters, return error*/

Delete this comment as well.  It's pointless.  (And the curly braces).

> >  		return -EINVAL;
> 

regards,
dan carpenter