linux-kernel - Re: [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201214143632.oiqmvpkai7kurc2d@holly.lan>
Date:   Mon, 14 Dec 2020 14:36:32 +0000
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>
Cc:     lee.jones@...aro.org, jingoohan1@...il.com,
        b.zolnierkie@...sung.com, dri-devel@...ts.freedesktop.org,
        linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] backlight: sky81452-backlight: convert comma to
 semicolon

On Mon, Dec 14, 2020 at 09:34:58PM +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>

Weird! I guess it was harmless but still seriously weird ;-)

Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>

Thanks!


> ---
>  drivers/video/backlight/sky81452-backlight.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
> index 8268ac43d54f..c95e0de7f4e7 100644
> --- a/drivers/video/backlight/sky81452-backlight.c
> +++ b/drivers/video/backlight/sky81452-backlight.c
> @@ -291,7 +291,7 @@ static int sky81452_bl_probe(struct platform_device *pdev)
>  	}
>  
>  	memset(&props, 0, sizeof(props));
> -	props.max_brightness = SKY81452_MAX_BRIGHTNESS,
> +	props.max_brightness = SKY81452_MAX_BRIGHTNESS;
>  	name = pdata->name ? pdata->name : SKY81452_DEFAULT_NAME;
>  	bd = devm_backlight_device_register(dev, name, dev, regmap,
>  						&sky81452_bl_ops, &props);
> -- 
> 2.22.0
>