linux-kernel - Re: [RFC PATCH 05/12] pinctrl: sunxi: add pinctrl driver for V831/V833

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5C8F8115-4DE6-4000-84DF-8D3BE2574713@aosc.io>
Date:   Mon, 14 Dec 2020 23:19:48 +0800
From:   Icenowy Zheng <icenowy@...c.io>
To:     Maxime Ripard <maxime@...no.tech>
CC:     Rob Herring <robh+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio@...r.kernel.org
Subject: Re: [RFC PATCH 05/12] pinctrl: sunxi: add pinctrl driver for V831/V833



于 2020年12月14日 GMT+08:00 下午10:21:18, Maxime Ripard <maxime@...no.tech> 写到:
>On Sat, Dec 12, 2020 at 12:04:23PM +0800, Icenowy Zheng wrote:
>> V831/V833 are new chips from Allwinner. They're the same die with
>> different package.
>> 
>> Add a pinctrl driver for them.
>> 
>> The difference between V831/V833 pinctrl is implemented based on the
>> user manual.
>> 
>> Cc: Linus Walleij <linus.walleij@...aro.org>
>> Cc: linux-gpio@...r.kernel.org
>> Signed-off-by: Icenowy Zheng <icenowy@...c.io>
>> ---
>>  drivers/pinctrl/sunxi/Kconfig              |   5 +
>>  drivers/pinctrl/sunxi/Makefile             |   1 +
>>  drivers/pinctrl/sunxi/pinctrl-sun8i-v83x.c | 743
>+++++++++++++++++++++
>>  drivers/pinctrl/sunxi/pinctrl-sunxi.h      |   2 +
>>  4 files changed, 751 insertions(+)
>>  create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun8i-v83x.c
>> 
>> diff --git a/drivers/pinctrl/sunxi/Kconfig
>b/drivers/pinctrl/sunxi/Kconfig
>> index 593293584ecc..fc13335a3eda 100644
>> --- a/drivers/pinctrl/sunxi/Kconfig
>> +++ b/drivers/pinctrl/sunxi/Kconfig
>> @@ -73,6 +73,11 @@ config PINCTRL_SUN8I_V3S
>>  	default MACH_SUN8I
>>  	select PINCTRL_SUNXI
>>  
>> +config PINCTRL_SUN8I_V83X
>> +	bool "Support for the Allwinner V831/V833 PIO"
>> +	default MACH_SUN8I
>> +	select PINCTRL_SUNXI
>> +
>
>We're not using the wildcard much, and I'd rather be consistent with
>the
>name / Kconfig option scheme used for the clock driver (and the rest of
>the SoCs in a similar situation)

Well, call everything V831, or call everything V833, or call things usable 
on V831 V831 and things only available to V833 V833?

>
>Maxime