linux-kernel - Re: [PATCH] jump_label: Do not profile branch annotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201214103335.3cb2d0bb@gandalf.local.home>
Date:   Mon, 14 Dec 2020 10:33:35 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>, Jason Baron <jbaron@...mai.com>
Subject: Re: [PATCH] jump_label: Do not profile branch annotations

On Mon, 14 Dec 2020 09:52:06 +0100
Peter Zijlstra <peterz@...radead.org> wrote:

> On Fri, Dec 11, 2020 at 04:37:54PM -0500, Steven Rostedt wrote:
> > From: Steven Rostedt (VMware) <rostedt@...dmis.org>
> > 
> > While running my branch profiler that checks for incorrect "likely" and
> > "unlikely"s around the kernel, there's a large number of them that are
> > incorrect due to being "static_branches".
> > 
> > As static_branches are rather special, as they are likely or unlikely for
> > other reasons than normal annotations are used for, there's no reason to
> > have them be profiled.
> > 
> > Expose the "unlikely_notrace" and "likely_notrace" so that the
> > static_branch can use them, and have them be ignored by the branch
> > profilers.  
> 
> The less that abomination does the better ;-), I'll take it through tip
> then?

Sure, go ahead.

Thanks.

-- Steve