linux-kernel - Re: [PATCH 01/15] irqchip: Allow to compile bcmstb on other platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Dec 2020 16:27:31 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Marc Zyngier <maz@...nel.org>
Cc:     Eric Anholt <eric@...olt.net>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Daniel Vetter <daniel.vetter@...el.com>,
        David Airlie <airlied@...ux.ie>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        linux-kernel@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Dave Stevenson <dave.stevenson@...pberrypi.com>,
        linux-rpi-kernel@...ts.infradead.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 01/15] irqchip: Allow to compile bcmstb on other platforms

Hi Marc,

On Thu, Dec 10, 2020 at 05:59:09PM +0000, Marc Zyngier wrote:
> On 2020-12-10 13:46, Maxime Ripard wrote:
> > The BCM2711 uses a number of instances of the bcmstb-l2 controller in
> > its
> > display engine. Let's allow the driver to be enabled through KConfig.
> > 
> > Signed-off-by: Maxime Ripard <maxime@...no.tech>
> > ---
> >  drivers/irqchip/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> > index c6098eee0c7c..f1e58de117dc 100644
> > --- a/drivers/irqchip/Kconfig
> > +++ b/drivers/irqchip/Kconfig
> > @@ -131,7 +131,7 @@ config BCM7120_L2_IRQ
> >  	select IRQ_DOMAIN
> > 
> >  config BRCMSTB_L2_IRQ
> > -	bool
> > +	bool "Broadcom STB L2 Interrupt Controller"
> >  	select GENERIC_IRQ_CHIP
> >  	select IRQ_DOMAIN
> 
> I'm always sceptical of making interrupt controllers user-selectable.
> Who is going to know that they need to pick that one?
> 
> I'd be much more in favour of directly selecting this symbol
> from DRM_VC4_HDMI_CEC, since there is an obvious dependency.

It's a bit weird to me that the HDMI CEC support selects it, since that
interrupt controller is external and here no matter what. Would
selecting it from the ARCH_* Kconfig option work for you?

Thanks!
Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)