linux-kernel - Re: [PATCH] spi: spi-qcom-qspi: Use irq trigger flags from firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=WWe-0v1=kzw4XGQ9TFUkFcf2nAx0so6TFBg74JH6bVmw@mail.gmail.com>
Date:   Mon, 14 Dec 2020 08:08:55 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Mark Brown <broonie@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Mukesh Kumar Savaliya <msavaliy@...eaurora.org>,
        Akash Asthana <akashast@...eaurora.org>
Subject: Re: [PATCH] spi: spi-qcom-qspi: Use irq trigger flags from firmware

Hi,

On Sat, Dec 12, 2020 at 9:29 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> We don't need to force this to be trigger high here, as the firmware
> properly configures the irq flags already. Drop it to save a line.
>
> Cc: Douglas Anderson <dianders@...omium.org>
> Cc: Rajendra Nayak <rnayak@...eaurora.org>
> Cc: Mukesh Kumar Savaliya <msavaliy@...eaurora.org>
> Cc: Akash Asthana <akashast@...eaurora.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
>  drivers/spi/spi-qcom-qspi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c
> index 5eed88af6899..8e70f5e63e0b 100644
> --- a/drivers/spi/spi-qcom-qspi.c
> +++ b/drivers/spi/spi-qcom-qspi.c
> @@ -516,8 +516,7 @@ static int qcom_qspi_probe(struct platform_device *pdev)
>         ret = platform_get_irq(pdev, 0);
>         if (ret < 0)
>                 goto exit_probe_master_put;
> -       ret = devm_request_irq(dev, ret, qcom_qspi_irq,
> -                       IRQF_TRIGGER_HIGH, dev_name(dev), ctrl);
> +       ret = devm_request_irq(dev, ret, qcom_qspi_irq, 0, dev_name(dev), ctrl);

I don't feel that the old code is really wrong, but I guess it is
weird that it's double-specified (both in the code and in the dts).
...so this is OK w/ me.

Reviewed-by: Douglas Anderson <dianders@...omium.org>