linux-kernel - Re: [PATCH v4 1/2] Partially revert ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201214175009.GD4880@sirena.org.uk>
Date:   Mon, 14 Dec 2020 17:50:09 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Srinivasa Rao Mandadapu <srivasam@...eaurora.org>
Cc:     agross@...nel.org, bjorn.andersson@...aro.org, lgirdwood@...il.com,
        robh+dt@...nel.org, plai@...eaurora.org, bgoswami@...eaurora.org,
        perex@...ex.cz, tiwai@...e.com, srinivas.kandagatla@...aro.org,
        rohitkr@...eaurora.org, linux-arm-msm@...r.kernel.org,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        V Sujith Kumar Reddy <vsujithk@...eaurora.org>
Subject: Re: [PATCH v4 1/2] Partially revert ASoC: qcom: Fix enabling BCLK
 and LRCLK in LPAIF invalid state

On Mon, Dec 14, 2020 at 06:13:22PM +0530, Srinivasa Rao Mandadapu wrote:
> On 12/1/2020 11:21 PM, Mark Brown wrote:

> > > Later from review comments by Srinivas kandagatla, I got to know
> > > 
> > > about regcache sync APIs, which can be used  to sync cache after resume and
> > > 
> > > HW registers can be updated with  original values. With that playback can be
> > > continued.

> > > So is the reason, I am reverting partial changes in the commit b1824968221c.

> > I don't understand why a fix for the register cache not being in sync
> > with the hardware doesn't involve syncing the register cache with the
> > hardware.

> I am sorry I couldn't understand your point. Could you please elaborate your
> query?

Your changelog talks about syncing the cache but neither the driver nor
your change actually does that.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)