linux-kernel - Re: [PATCH] fuse: clean up redundant assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53733a62-c04c-48b4-af0c-e8bcaeca948b@cn.fujitsu.com>
Date:   Mon, 14 Dec 2020 13:43:26 +0800
From:   Ruan Shiyang <ruansy.fnst@...fujitsu.com>
To:     <miklos@...redi.hu>, <linux-fsdevel@...r.kernel.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fuse: clean up redundant assignment

Hi guys,

any ideas?


--
Thanks,
Ruan Shiyang.

On 2020/11/26 下午12:03, Shiyang Ruan wrote:
> The 'err' was assigned to -ENOMEM in just few lines above, no need to be
> assigned again.
> 
> Signed-off-by: Shiyang Ruan <ruansy.fnst@...fujitsu.com>
> ---
>   fs/fuse/dir.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index ff7dbeb16f88..f28eb54517ff 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -528,7 +528,6 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry,
>   	if (!forget)
>   		goto out_err;
>   
> -	err = -ENOMEM;
>   	ff = fuse_file_alloc(fm);
>   	if (!ff)
>   		goto out_put_forget_req;
>