linux-kernel - Re: [PATCH v2 4/5] amba: Make the remove callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201214204046.xopipytz4ws7j72f@pengutronix.de>
Date:   Mon, 14 Dec 2020 21:40:46 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Matt Mackall <mpm@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Dan Williams <dan.j.williams@...el.com>,
        Vinod Koul <vkoul@...nel.org>, Eric Anholt <eric@...olt.net>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Alex Williamson <alex.williamson@...hat.com>,
        Cornelia Huck <cohuck@...hat.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc:     Rob Herring <robh@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Russell King <linux@...linux.org.uk>,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de,
        linux-arm-kernel@...ts.infradead.org,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v2 4/5] amba: Make the remove callback return void

On Thu, Dec 03, 2020 at 02:01:41PM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> [This is a resend because somehow my MUA failed to parse the To: list
> and dropped it without me noticing it. Sorry to those who got it twice
> now.]
> 
> On Tue, Nov 24, 2020 at 02:31:38PM +0100, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > 
> > All amba drivers return 0 in their remove callback. Together with the
> > driver core ignoring the return value anyhow, it doesn't make sense to
> > return a value here.
> > 
> > Change the remove prototype to return void, which makes it explicit that
> > returning an error value doesn't work as expected. This simplifies changing
> > the core remove callback to return void, too.
> > 
> > Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>
> > Reviewed-by: Arnd Bergmann <arnd@...db.de>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > ---
> >  drivers/amba/bus.c                                 | 5 ++---
> >  drivers/char/hw_random/nomadik-rng.c               | 3 +--
> >  drivers/dma/pl330.c                                | 3 +--
> >  drivers/gpu/drm/pl111/pl111_drv.c                  | 4 +---
> >  drivers/hwtracing/coresight/coresight-catu.c       | 3 +--
> >  drivers/hwtracing/coresight/coresight-cpu-debug.c  | 4 +---
> >  drivers/hwtracing/coresight/coresight-cti-core.c   | 4 +---
> >  drivers/hwtracing/coresight/coresight-etb10.c      | 4 +---
> >  drivers/hwtracing/coresight/coresight-etm3x-core.c | 4 +---
> >  drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +---
> >  drivers/hwtracing/coresight/coresight-funnel.c     | 4 ++--
> >  drivers/hwtracing/coresight/coresight-replicator.c | 4 ++--
> >  drivers/hwtracing/coresight/coresight-stm.c        | 4 +---
> >  drivers/hwtracing/coresight/coresight-tmc-core.c   | 4 +---
> >  drivers/hwtracing/coresight/coresight-tpiu.c       | 4 +---
> >  drivers/i2c/busses/i2c-nomadik.c                   | 4 +---
> >  drivers/input/serio/ambakmi.c                      | 3 +--
> >  drivers/memory/pl172.c                             | 4 +---
> >  drivers/memory/pl353-smc.c                         | 4 +---
> >  drivers/mmc/host/mmci.c                            | 4 +---
> >  drivers/rtc/rtc-pl030.c                            | 4 +---
> >  drivers/rtc/rtc-pl031.c                            | 4 +---
> >  drivers/spi/spi-pl022.c                            | 5 ++---
> >  drivers/tty/serial/amba-pl010.c                    | 4 +---
> >  drivers/tty/serial/amba-pl011.c                    | 3 +--
> >  drivers/vfio/platform/vfio_amba.c                  | 3 +--
> >  drivers/video/fbdev/amba-clcd.c                    | 4 +---
> >  drivers/watchdog/sp805_wdt.c                       | 4 +---
> >  include/linux/amba/bus.h                           | 2 +-
> >  sound/arm/aaci.c                                   | 4 +---
> >  30 files changed, 34 insertions(+), 80 deletions(-)
> 
> I failed to Cc: the relevant maintainers before, so that's why I'm
> adressing you now. The idea is to let this series (completely available at
> https://lore.kernel.org/linux-arm-kernel/20201124133139.3072124-1-uwe@kleine-koenig.org/)
> go in via Russell King's tree, so an Ack from you would be great. If you
> want the original in your mailbox, just tell me and I can send you a
> bounce (or use b4 on the above link).

Technically there are still some maintainers' ack missing but I'd really
like to get this series applied.  As I don't want to make people angry
I'm asking once more for your Acks.

Or is the stuff outside of drivers/amba trivial enough to merge it even
without each maintainer's ack? (It's changing some functions from
returning int to void and dropping "return 0;".)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)