linux-kernel - Re: [PATCH] regulator: pf8x00: Use specific compatible strings for devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMty3ZDBWAJG3cPYnYtZY4ReOEO6iF5gscs+BLJEQ5WftawmQw@mail.gmail.com>
Date:   Wed, 16 Dec 2020 01:49:58 +0530
From:   Jagan Teki <jagan@...rulasolutions.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Adrien Grassein <adrien.grassein@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: pf8x00: Use specific compatible strings for devices

On Tue, Dec 15, 2020 at 6:50 PM Mark Brown <broonie@...nel.org> wrote:
>
> The pf8x00 driver supports three devices, the DT compatible strings
> and I2C IDs should enumerate these specifically rather than using a
> wildcard so that we don't collide with anything incompatible in the
> same ID range in the future and so that we can handle any software
> visible differences between the variants we find.

Thanks for the patch.

>
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>  .../bindings/regulator/nxp,pf8x00-regulator.yaml          | 6 ++++--
>  drivers/regulator/pf8x00-regulator.c                      | 8 ++++++--

I think the bindings patch would be separate? otherwise,

Reviewed-by: Jagan Teki <jagan@...rulasolutions.com>