linux-kernel - Re: [PATCH 0/3] mm: Some rework on zap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201215203959.GA6519@xz-x1>
Date:   Tue, 15 Dec 2020 15:39:59 -0500
From:   Peter Xu <peterx@...hat.com>
To:     linux-kernel@...r.kernel.org, linux-mm@...ck.org
Cc:     Andrea Arcangeli <aarcange@...hat.com>,
        "Kirill A . Shutemov" <kirill@...temov.name>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 0/3] mm: Some rework on zap_details

On Mon, Dec 07, 2020 at 09:50:19PM -0500, Peter Xu wrote:
> Posted this small series out to rework zap_details a bit, before adding
> something new in.  Hopefully it makes things slighly clearer.
> 
> Smoke test only.  Please have a look, thanks.
> 
> Peter Xu (3):
>   mm: Drop first_index/last_index in zap_details
>   mm: Introduce zap_details.zap_flags
>   mm: Introduce ZAP_FLAG_SKIP_SWAP

Some more information on "before adding something new in" - the new flag as a
reference but not yet posted anywhere...

https://github.com/xzpeter/linux/commit/102790511a1a25b7be841fb2059a8c8d8f1a87b2

I still think this small series worths to be reviewed/merged even before that
new flag, because patch 1 should definitely be something good to have, patch 2
prepares for patch 3 and the new bit (which can be seen as optional), but patch
3 should help make things clearer rather than using non-null "details" pointer
to show "whether we should skip swap entries", which can be easily misused IMHO
when someone accidentally replaced one "details==NULL" with some valid pointer.

Of course I can repost these series with the larger one when time comes too,
but I'd still like to at least get a NO early if there is...

Thanks,

-- 
Peter Xu