linux-kernel - Re: [PATCH v5] Serial: silabs si4455 serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201215204617.GA14153@dev>
Date:   Tue, 15 Dec 2020 20:46:17 +0000
From:   József Horváth <info@...istro.hu>
To:     Rob Herring <robh@...nel.org>
Cc:     'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>,
        'Jiri Slaby' <jirislaby@...nel.org>,
        linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] Serial: silabs si4455 serial driver

On Tue, Dec 15, 2020 at 02:02:19PM -0600, Rob Herring wrote:
> On Tue, Dec 15, 2020 at 07:20:07AM +0000, József Horváth wrote:
> > This is a serial port driver for
> >  Silicon Labs Si4455 Sub-GHz transciver.
> > 
> >  - fixed: dt-bindings: silabs,si4455: serial.yaml reference added
> 
> The revision history should be after the '---' so it is not in the git 
> history when applied.
> 
> > Signed-off-by: József Horváth <info@...istro.hu>
> > ---
> >  .../bindings/serial/silabs,si4455.yaml        |   98 ++
> 
> Please make the binding a separate patch.
> 
> >  MAINTAINERS                                   |    6 +
> > +  silabs,ez-config:
> > +    description:
> > +      Radio configuration data file name.
> > +    $ref: /schemas/types.yaml#/definitions/string
> > +    items:
> > +      pattern: ^[0-9a-z\._\-]{1,255}$
> 
> We use 'firmware-name' property for this purpose. 

Yes, I saw it, but in my mind it is still a configuration
 and this name covers the meaning,
 but I can rename it, the "description" above describes the real meaning.

> 
> Looks good otherwise.

Thank you and everyone who read or commented my code.

> 
> > +
> > +required:
> > +  - reg
> > +  - interrupts
> > +  - spi-max-frequency
> > +  - shutdown-gpios
> > +  - silabs,package-size
> > +  - silabs,tx-channel
> > +  - silabs,rx-channel
> > +  - silabs,ez-config
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    spi {
> > +      #address-cells = <1>;
> > +      #size-cells = <0>;
> > +      si4455_0: serial@0 {
> > +        compatible = "silabs,si4455";
> > +        reg = <0>;
> > +        interrupt-parent = <&gpio>;
> > +        interrupts = <7 2>;
> > +        shutdown-gpios = <&gpio 26 1>;
> > +        spi-max-frequency = <300000>;
> > +        silabs,package-size = <30>;
> > +        silabs,tx-channel = <1>;
> > +        silabs,rx-channel = <2>;
> > +        silabs,ez-config = "si4455_spi0_0.ez.bin";
> > +      };
> > +    };
> > +...

Üdvözlettel / Best regards:
József Horváth