linux-kernel - Re: [Aspeed,ncsi-rx, v1 1/1] net: ftgmac100: Fix AST2600 EVB NCSI RX issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Dec 2020 09:17:36 +1030
From:   "Andrew Jeffery" <andrew@...id.au>
To:     "Hongwei Zhang" <hongweiz@....com>, linux-aspeed@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org,
        "Jakub Kicinski" <kuba@...nel.org>,
        "David Miller" <davem@...emloft.net>
Cc:     "Joel Stanley" <joel@....id.au>
Subject: Re: [Aspeed,ncsi-rx, v1 1/1] net: ftgmac100: Fix AST2600 EVB NCSI RX issue

On Wed, 16 Dec 2020, at 05:53, Hongwei Zhang wrote:
> Fix AST2600 EVB NCSI RX timeout issue by removing FTGMAC100_RXDES0_RX_ERR bit
> from macro RXDES0_ANY_ERROR.

But why? What is wrong with the EVB that this change resolves? Which revision 
of the EVB?

The change affects all designs using the MAC, not just the AST2600 EVB. Why is 
this patch an appropriate course of action? Can we not add a quirk targeting the
specific board (e.g. a devicetree property)?

Andrew