linux-kernel - Re: [PATCH v5] dt-bindings: usb: Add new compatible string for AM64 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c31059ae-0923-ee03-a3ed-954a58a12c1a@ti.com>
Date:   Tue, 15 Dec 2020 10:00:14 +0530
From:   Aswath Govindraju <a-govindraju@...com>
To:     Rob Herring <robh@...nel.org>
CC:     Vignesh Raghavendra <vigneshr@...com>,
        Sekhar Nori <nsekhar@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Roger Quadros <rogerq@...com>, <linux-usb@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5] dt-bindings: usb: Add new compatible string for AM64
 SoC

Hi Rob,
On 15/12/20 2:18 am, Rob Herring wrote:
> On Mon, Dec 14, 2020 at 07:31:09PM +0530, Aswath Govindraju wrote:
>> Add compatible string in j721e-usb binding file as the same USB subsystem
>> is present in AM64.
>>
>> Signed-off-by: Aswath Govindraju <a-govindraju@...com>
>> ---
>>
>> Changes since v4:
>>  - used oneOf instead of enum, as the schema has to convey that the strings
>>    ti,j721e-usb and ti,am64-usb can be used combined or seperately in the
>>    DT nodes.
>>
>> Changes since v3:
>>  - used enum instead of anyOf.
>>
>> Changes since v2:
>>  - added changes done over the versions.
>>
>> Changes since v1:
>>  - replaced the '\t' at the beginning of the lines with spaces as it was
>>   causing the dt_binding_check to fail.
>>
>>  Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> index 388245b91a55..21e51ceca293 100644
>> --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> @@ -11,8 +11,12 @@ maintainers:
>>  
>>  properties:
>>    compatible:
>> -    items:
>> +    oneOf:
>>        - const: ti,j721e-usb
>> +      - const: ti,am64-usb
>> +      - items:
>> +          - ti,j721e-usb
>> +          - ti,am64-usb
> 
>                ^
> 
> const needed before the strings
> 

Thank you for the comments. I am very sorry for this error, I forgot to
add my changes to  the commit before creating the patch. I have sent a
respin (v6).

Thanks,
Aswath

>>  
>>    reg:
>>      description: module registers
>> -- 
>> 2.17.1
>>