linux-kernel - Re: [PATCH v1] serial: 8250_fintek: Print Fintek chip name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Dec 2020 08:29:41 +0800
From:   "Ji-Ze Hong (Peter Hong)" <hpeter@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Flavio Suligoi <f.suligoi@...m.it>
Cc:     Jiri Slaby <jirislaby@...nel.org>,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] serial: 8250_fintek: Print Fintek chip name

Hi,

Greg Kroah-Hartman 於 2020/12/14 下午 09:42 寫道:
>>   	pdata->pid = chip;
>> +
>> +	pr_info("%s%s%s Fintek %s\n",
>> +		uart->port.dev ? dev_name(uart->port.dev) : "",
>> +		uart->port.dev ? ": " : "",
>> +		uart->port.name,
>> +		chip_name);
> 
> Drivers, if all goes well, should not print anything to the kernel log.
> This isn't ok.
> 
> And even if it was, dev_info() would be the correct thing to do...

Maybe can transform pr_info() to dev_dbg() for debug usage ?

-- 
With Best Regards,
Peter Hong