linux-kernel - Re: [PATCH] Input: raydium_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 14 Dec 2020 22:27:58 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Jeffrey Lin <jeffrey.lin@...dium.corp-partner.google.com>
Cc:     Furquan Shaikh <furquan@...gle.com>,
        Sean Paul <seanpaul@...omium.org>, rrangel@...omium.org,
        dan.carpenter@...cle.com, jeffrey.lin@...-ic.com, KP.li@...-ic.com,
        calvin.tseng@...-ic.com, simba.hsu@...-ic.com,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH] Input: raydium_ts_i2c: Do not send zero length

On Tue, Dec 15, 2020 at 02:07:00PM +0800, Jeffrey Lin wrote:
> Yes, it is.

Great!

> 
> Dmitry Torokhov <dmitry.torokhov@...il.com> 於 2020年12月15日 週二 下午1:48寫道：
> 
> > Hi Jeffrey,
> >
> > On Tue, Dec 15, 2020 at 11:21:06AM +0800, jeffrey.lin wrote:
> > > Add default write command package to prevent i2c quirk error of zero
> > > data length as Raydium touch firmware update is executed.
> > >
> > > Signed-off-by: jeffrey.lin <jeffrey.lin@...-ic.com>
> > > BUG=b:174207906
> > > TEST=Successfully tested update Raydium touch firmware over 100 times
> > > Change-Id: I311b0d26d7642bb800547cd0e87013be17cb7e1b

Could you please drop these BUG/TEST/Change-Id and re-send from your
main account (jeffrey.lin@...-ic.com)? Or simply add "From:" tag:

From: Jeffrey Lin <jeffrey.lin@...-ic.com>

> > > ---
> > >  drivers/input/touchscreen/raydium_i2c_ts.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c
> > b/drivers/input/touchscreen/raydium_i2c_ts.c
> > > index 603a948460d64..4d2d22a869773 100644
> > > --- a/drivers/input/touchscreen/raydium_i2c_ts.c
> > > +++ b/drivers/input/touchscreen/raydium_i2c_ts.c
> > > @@ -445,6 +445,7 @@ static int raydium_i2c_write_object(struct
> > i2c_client *client,
> > >                                   enum raydium_bl_ack state)
> > >  {
> > >       int error;
> > > +     static const u8 cmd[] = { 0xFF, 0x39 };
> > >
> > >       error = raydium_i2c_send(client, RM_CMD_BOOT_WRT, data, len);
> > >       if (error) {
> > > @@ -453,7 +454,7 @@ static int raydium_i2c_write_object(struct
> > i2c_client *client,
> > >               return error;
> > >       }
> > >
> > > -     error = raydium_i2c_send(client, RM_CMD_BOOT_ACK, NULL, 0);
> > > +     error = raydium_i2c_send(client, RM_CMD_BOOT_ACK, cmd,
> > sizeof(cmd));
> >
> > Is this supported by all firmwares?
> >
> > >       if (error) {
> > >               dev_err(&client->dev, "Ack obj command failed: %d\n",
> > error);
> > >               return error;
> > > --
> > > 2.26.2
> > >
> >
> > Thanks.
> >
> > --
> > Dmitry
> >

Thanks!

-- 
Dmitry