linux-kernel - Re: [PATCH 1/4] arm64: defconfig: Enable Librem5 Devkit components

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201215091729.GC29321@kozik-lap>
Date:   Tue, 15 Dec 2020 10:17:29 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Guido Günther <agx@...xcpu.org>
Cc:     Rob Herring <robh+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Martin Kepplinger <martink@...teo.de>,
        Angus Ainslie <angus@...ea.ca>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Li Yang <leoyang.li@....com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Vinod Koul <vkoul@...nel.org>,
        Anson Huang <Anson.Huang@....com>,
        Michael Walle <michael@...le.cc>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        phone-devel@...r.kernel.org
Subject: Re: [PATCH 1/4] arm64: defconfig: Enable Librem5 Devkit components

On Sun, Dec 13, 2020 at 06:17:11PM +0100, Guido Günther wrote:
> This enables
> 
> - touchscreen: CONFIG_TOUCHSCREEN_GOODIX
> - charge controller: CONFIG_CHARGER_BQ25890
> - audio codec: CONFIG_SND_SOC_IMX_SGTL5000
> - rtc: CONFIG_RTC_DRV_M41T80
> - magnetometer: CONFIG_IIO_ST_MAGN_3AXIS
> - pwm: CONFIG_PWM_IMX27
> - modem codec: CONFIG_SND_SOC_GTM601
> - modem serial: CONFIG_USB_SERIAL_OPTION

Do not repeat the contents of the patch. We can easily see which configs
you enable. Instead, please name the devices you want to use, not the
CONFIG entries.  Several drivers actually support multiple devices.

Describe also the board you are enabling it for. You wrote only
"Librem5", but I am not sure whether this is specific enough. Is it even
on NXP i.MX processor? Maybe on something else?

This is a generic defconfig so your change will affect everyone.

Best regards,
Krzysztof