lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 15 Dec 2020 09:34:45 +0800
From:   Huazhong Tan <>
To:     Colin King <>,
        Yisen Zhuang <>,
        Salil Mehta <>,
        "David S . Miller" <>,
        Jakub Kicinski <>,
        Jian Shen <>, <>
CC:     <>, <>
Subject: Re: [PATCH][next] net: hns3: fix expression that is currently always

On 2020/12/15 8:00, Colin King wrote:
> From: Colin Ian King<>
> The ||  condition in hdev->fd_active_type != HCLGE_FD_ARFS_ACTIVE ||
> hdev->fd_active_type != HCLGE_FD_RULE_NONE will always be true because
> hdev->fd_active_type cannot be equal to two different values at the same
> time. The expression is always true which is not correct. Fix this by
> replacing || with && to correct the logic in the expression.
> Addresses-Coverity: ("Constant expression result")
> Fixes: 0205ec041ec6 ("net: hns3: add support for hw tc offload of tc flower")
> Signed-off-by: Colin Ian King<>

Reviewed-by: Huazhong Tan <>


Powered by blists - more mailing lists