linux-kernel - Re: [PATCH v3 00/12] Introduce threaded trace streaming for basic perf record operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54c121cf-1295-30b4-adc3-c96c2e91ca55@huawei.com>
Date:   Tue, 15 Dec 2020 18:05:14 +0300
From:   Alexei Budankov <abudankov@...wei.com>
To:     Namhyung Kim <namhyung@...nel.org>,
        "Bayduraev, Alexey V" <alexey.v.bayduraev@...ux.intel.com>
CC:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        "Adrian Hunter" <adrian.hunter@...el.com>,
        Alexey Bayduraev <alexey.v.bayduraev@...ux.intel.com>,
        Alexander Antonov <alexander.antonov@...ux.intel.com>,
        <abudankov@...wei.com>
Subject: Re: [PATCH v3 00/12] Introduce threaded trace streaming for basic
 perf record operation

Hi,

On 20.11.2020 12:45, Namhyung Kim wrote:
> Hi,
> 
> Thanks for working on this!

Thanks for your review.
Just spotted comments for this version.
Sorry for delay.

> 
> On Mon, Nov 16, 2020 at 03:12:47PM +0300, Alexey Budankov wrote:
>>
>> Changes in v3:
>> - avoided skipped redundant patch 3/15
>> - applied "data file" and "data directory" terms allover the patch set
>> - captured Acked-by: tags by Namhyung Kim
>> - avoided braces where don't needed
>> - employed thread local variable for serial trace streaming 
>> - added specs for --thread option - core, socket, numa and user defined
>> - added parallel loading of data directory files similar to the prototype [1]
> 
> Can you please consider splitting tracing records (FORK/MMAP/...) into
> a separate file?  I think this change would put too much burden to the
> perf report side.  I'm saying this repeatedly because I'm afraid that
> it'd be harder to change later once we accept this approach/format..

Alexey Bayduraev in To/Cc is going to proceed with this work
so there are chances to have updated version soon.

Thanks,
Alexei