linux-kernel - Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201215152420.GC658008@krava>
Date:   Tue, 15 Dec 2020 16:24:20 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Ingo Molnar <mingo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Michael Petlan <mpetlan@...hat.com>,
        Ian Rogers <irogers@...gle.com>,
        Stephane Eranian <eranian@...gle.com>,
        Alexei Budankov <abudankov@...wei.com>
Subject: Re: [PATCH 2/3] perf tools: Allow to enable/disable events via
 control file

On Tue, Dec 15, 2020 at 12:14:13PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Dec 10, 2020 at 09:43:29PM +0100, Jiri Olsa escreveu:
> > Adding new control events to enable/disable specific event.
> > The interface string for control file are:
> > 
> >   'enable-<EVENT NAME>'
> >   'disable-<EVENT NAME>'
> 
> Wwy do we have "enable-" as the "tag" for this?

the whole 'enable-' is prefix for command that enables specific event
following '-' starts the event name

> 
> Also is it possible to use "enable sched:*" and have that match what is
> in the evlist and enable (or disable, if using "disable sched:*") what
> matches?

yep, that should be possible to add

> 
> This second suggestion can be done on top of this, i.e. as an
> enhancement, but mixing up the command (enable, disable) with its
> arguments looks strange.

the '-' determines that there's event name following,
pure 'enable' switches on everything

jirka