linux-kernel - Re: [RFC PATCH] RFC: drivers: gpio: helper for generic pin IRQ handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <333a4bab-682c-6f5d-f24e-3f9ebe77f536@metux.net>
Date:   Tue, 15 Dec 2020 17:00:09 +0100
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     Grygorii Strashko <grygorii.strashko@...com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        William Breathitt Gray <vilhelm.gray@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        joyce.ooi@...el.com, Andrew Jeffery <andrew@...id.au>,
        Hoan Tran <hoan@...amperecomputing.com>,
        Serge Semin <fancer.lancer@...il.com>, orsonzhai@...il.com,
        baolin.wang7@...il.com, zhang.lyra@...il.com,
        Andy Shevchenko <andy@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Kevin Hilman <khilman@...nel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Jun Nie <jun.nie@...aro.org>, Shawn Guo <shawnguo@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>
Subject: Re: [RFC PATCH] RFC: drivers: gpio: helper for generic pin IRQ
 handling

On 10.12.20 16:40, Grygorii Strashko wrote:

>> a) consolidating repeated patterns (eg. calling the actual irq handling)
>>     into gpiolib, (and later possibly use more fields already existing in
>>     struct gpio_chip for irq handling)
> 
> Even if there is some pattern It doesn't mean consolidation is always
> reasonable.
> one of the things to think about is compiler optimization and will/will
> not this change
> add additional

I dont think the compiler could optimize-out much of the replaced code.
Yes, there's an additional call - but does it really matter so much ?

If we drop the dev_warn() call, the gpiochip_handle_irq() function can
be made inline, so quite no extra costs.


--mtx

-- 
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287