lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 15 Dec 2020 17:00:09 +0100
From:   "Enrico Weigelt, metux IT consult" <>
To:     Grygorii Strashko <>,
        Andy Shevchenko <>,
        "Enrico Weigelt, metux IT consult" <>
Cc:     Linux Kernel Mailing List <>,
        William Breathitt Gray <>,
        Linus Walleij <>,
        Bartosz Golaszewski <>,, Andrew Jeffery <>,
        Hoan Tran <>,
        Serge Semin <>,,,,
        Andy Shevchenko <>,
        Matthias Brugger <>,
        Santosh Shilimkar <>,
        Kevin Hilman <>,
        Manivannan Sadhasivam <>,
        Jun Nie <>, Shawn Guo <>,
        Philipp Zabel <>,
        "open list:GPIO SUBSYSTEM" <>,
        Linux OMAP Mailing List <>
Subject: Re: [RFC PATCH] RFC: drivers: gpio: helper for generic pin IRQ

On 10.12.20 16:40, Grygorii Strashko wrote:

>> a) consolidating repeated patterns (eg. calling the actual irq handling)
>>     into gpiolib, (and later possibly use more fields already existing in
>>     struct gpio_chip for irq handling)
> Even if there is some pattern It doesn't mean consolidation is always
> reasonable.
> one of the things to think about is compiler optimization and will/will
> not this change
> add additional

I dont think the compiler could optimize-out much of the replaced code.
Yes, there's an additional call - but does it really matter so much ?

If we drop the dev_warn() call, the gpiochip_handle_irq() function can
be made inline, so quite no extra costs.


Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering -- +49-151-27565287

Powered by blists - more mailing lists