linux-kernel - Re: [PATCH] drm/i915: remove h from printk format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12579dc7-603e-2fbe-85c0-0a4110b8992a@redhat.com>
Date:   Tue, 15 Dec 2020 11:00:06 -0800
From:   Tom Rix <trix@...hat.com>
To:     Chris Wilson <chris@...is-wilson.co.uk>, airlied@...ux.ie,
        daniel@...ll.ch, daniele.ceraolospurio@...el.com,
        jani.nikula@...ux.intel.com, joonas.lahtinen@...ux.intel.com,
        lionel.g.landwerlin@...el.com, rodrigo.vivi@...el.com,
        tejaskumarx.surendrakumar.upadhyay@...el.com,
        tvrtko.ursulin@...el.com, venkata.s.dhanalakota@...el.com
Cc:     intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915: remove h from printk format specifier


On 12/15/20 10:13 AM, Chris Wilson wrote:
> Quoting trix@...hat.com (2020-12-15 14:41:01)
>> From: Tom Rix <trix@...hat.com>
>>
>> See Documentation/core-api/printk-formats.rst.
>> h should no longer be used in the format specifier for printk.
> It's understood by format_decode().
> * 'h', 'l', or 'L' for integer fields
>
> At least reference commit cbacb5ab0aa0 ("docs: printk-formats: Stop
> encouraging use of unnecessary %h[xudi] and %hh[xudi]") as to why the
> printk-formats.rst was altered so we know the code is merely in bad
> taste and not using undefined behaviour of printk.

Ok, i will fix this after the first run of patches.

Tom

> -Chris
>