linux-kernel - Re: [PATCH v4 2/9] rtc: mt6397: refine RTC_TC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201216214959.GT2814589@piout.net>
Date:   Wed, 16 Dec 2020 22:49:59 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Hsin-Hsiung Wang <hsin-hsiung.wang@...iatek.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Fei Shao <fshao@...omium.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Eddie Huang <eddie.huang@...iatek.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Yuchen Huang <yuchen.huang@...iatek.com>,
        Ran Bi <ran.bi@...iatek.com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-rtc@...r.kernel.org, srv_heupstream@...iatek.com
Subject: Re: [PATCH v4 2/9] rtc: mt6397: refine RTC_TC_MTH

On 16/12/2020 15:47:00+0800, Hsin-Hsiung Wang wrote:
> This patch adds RTC_TC_MTH_MASK to support new chips.
> 
> Signed-off-by: Yuchen Huang <yuchen.huang@...iatek.com>
> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@...iatek.com>
Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

> ---
>  drivers/rtc/rtc-mt6397.c       | 2 +-
>  include/linux/mfd/mt6397/rtc.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index 1894aded4c85..ea6da7476a5e 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -75,7 +75,7 @@ static int __mtk_rtc_read_time(struct mt6397_rtc *rtc,
>  	tm->tm_min = data[RTC_OFFSET_MIN];
>  	tm->tm_hour = data[RTC_OFFSET_HOUR];
>  	tm->tm_mday = data[RTC_OFFSET_DOM];
> -	tm->tm_mon = data[RTC_OFFSET_MTH];
> +	tm->tm_mon = data[RTC_OFFSET_MTH] & RTC_TC_MTH_MASK;
>  	tm->tm_year = data[RTC_OFFSET_YEAR];
>  
>  	ret = regmap_read(rtc->regmap, rtc->addr_base + RTC_TC_SEC, sec);
> diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h
> index c3748b53bf7d..068ae1c0f0e8 100644
> --- a/include/linux/mfd/mt6397/rtc.h
> +++ b/include/linux/mfd/mt6397/rtc.h
> @@ -36,6 +36,7 @@
>  #define RTC_AL_MASK_DOW                BIT(4)
>  
>  #define RTC_TC_SEC             0x000a
> +#define RTC_TC_MTH_MASK        0x000f
>  /* Min, Hour, Dom... register offset to RTC_TC_SEC */
>  #define RTC_OFFSET_SEC         0
>  #define RTC_OFFSET_MIN         1
> -- 
> 2.18.0
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com