lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 16 Dec 2020 13:59:56 -0800
From:   Florian Fainelli <>
To:     Jim Quinlan <>,
        Philipp Zabel <>,
        Hans de Goede <>,
        Jens Axboe <>,,
Cc:     Jim Quinlan <>,
        Florian Fainelli <>,
        "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" 
        open list <>
Subject: Re: [RESEND PATCH v3 1/2] ata: ahci_brcm: Fix use of BCM7216 reset

On 12/16/20 1:41 PM, Jim Quinlan wrote:
> From: Jim Quinlan <>
> This driver may use one of two resets controllers.  Keep them in separate
> variables to keep things simple.  The reset controller "rescal" is shared
> between the AHCI driver and the PCIe driver for the BrcmSTB 7216 chip.  Use
> devm_reset_control_get_optional_shared() to handle this sharing.
> Fixes: 272ecd60a636 ("ata: ahci_brcm: BCM7216 reset is self de-asserting")
> Fixes: c345ec6a50e9 ("ata: ahci_brcm: Support BCM7216 reset controller name")
> Signed-off-by: Jim Quinlan <>

Thanks a lot for fixing this Jim, given the reset lines are still
mutually exclusive the single variable along with the 7216 versus
another chip differentiation would still work, but I have no objection
to the approach you have taken:

Acked-by: Florian Fainelli <>

Powered by blists - more mailing lists