linux-kernel - Re: [PATCH v2 3/5] Bluetooth: advmon offload MSFT remove monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Dec 2020 12:33:00 +0800
From:   Archie Pusaka <apusaka@...gle.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     kbuild@...ts.01.org,
        linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        Marcel Holtmann <marcel@...tmann.org>, lkp@...el.com,
        kbuild-all@...ts.01.org,
        CrosBT Upstreaming <chromeos-bluetooth-upstreaming@...omium.org>,
        Archie Pusaka <apusaka@...omium.org>,
        Miao-chen Chou <mcchou@...omium.org>,
        Yun-Hao Chung <howardchung@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/5] Bluetooth: advmon offload MSFT remove monitor

Hi Dan,

On Wed, 16 Dec 2020 at 03:06, Dan Carpenter <dan.carpenter@...cle.com> wrote:
>
> Hi Archie,
>
> url:    https://github.com/0day-ci/linux/commits/Archie-Pusaka/MSFT-offloading-support-for-advertisement-monitor/20201215-163858
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
> config: i386-randconfig-m021-20201215 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> smatch warnings:
> net/bluetooth/msft.h:45 msft_remove_monitor() warn: signedness bug returning '(-95)'
>
> vim +45 net/bluetooth/msft.h
>
> d8ca4cbc63c57c8 Archie Pusaka  2020-12-15  41  static inline bool msft_remove_monitor(struct hci_dev *hdev,
>                                                              ^^^^
> d8ca4cbc63c57c8 Archie Pusaka  2020-12-15  42                                  struct adv_monitor *monitor,
> d8ca4cbc63c57c8 Archie Pusaka  2020-12-15  43                                  u16 handle)
> d8ca4cbc63c57c8 Archie Pusaka  2020-12-15  44  {
> d8ca4cbc63c57c8 Archie Pusaka  2020-12-15 @45   return -EOPNOTSUPP;
>                                                 ^^^^^^^^^^^^^^^^^^^
> change this to return false?
>
Thanks. Will fix.

> d8ca4cbc63c57c8 Archie Pusaka  2020-12-15  46  }
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Regards,
Archie