linux-kernel - Re: [PATCH] kfence: fix typo in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Dec 2020 00:43:56 +0100
From:   Marco Elver <elver@...gle.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     kbuild-all@...ts.01.org,
        Linux Memory Management List <linux-mm@...ck.org>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Jann Horn <jannh@...gle.com>,
        kernel test robot <lkp@...el.com>,
        kasan-dev <kasan-dev@...glegroups.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kfence: fix typo in test

On Wed, 16 Dec 2020 at 00:31, Marco Elver <elver@...gle.com> wrote:
> Fix a typo/accidental copy-paste that resulted in the obviously
> incorrect 'GFP_KERNEL * 2' expression.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Marco Elver <elver@...gle.com>
> ---
>  mm/kfence/kfence_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c
> index 1433a35a1644..f57c61c833e6 100644
> --- a/mm/kfence/kfence_test.c
> +++ b/mm/kfence/kfence_test.c
> @@ -665,7 +665,7 @@ static void test_krealloc(struct kunit *test)
>         for (; i < size * 3; i++) /* Fill to extra bytes. */
>                 buf[i] = i + 1;
>
> -       buf = krealloc(buf, size * 2, GFP_KERNEL * 2); /* Shrink. */
> +       buf = krealloc(buf, size * 2, GFP_KERNEL); /* Shrink. */
>         KUNIT_EXPECT_GE(test, ksize(buf), size * 2);
>         for (i = 0; i < size * 2; i++)
>                 KUNIT_EXPECT_EQ(test, buf[i], (char)(i + 1));
> --
> 2.29.2.684.gfbc64c5ab5-goog
>

This patch could, if appropriate, be squashed into "kfence: add test suite".

Thanks,
-- Marco