lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 16 Dec 2020 09:29:37 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "lee.jones@...aro.org" <lee.jones@...aro.org>
CC:     "khiem.nguyen.xt@...esas.com" <khiem.nguyen.xt@...esas.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        linux-power <linux-power@...rohmeurope.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "marek.vasut+renesas@...il.com" <marek.vasut+renesas@...il.com>,
        "yoshihiro.shimoda.uh@...esas.com" <yoshihiro.shimoda.uh@...esas.com>
Subject: Re: [PATCH v3 12/12] mfd: bd9571mwv: Add support for BD9574MWF


On Wed, 2020-12-16 at 09:02 +0000, Lee Jones wrote:
> On Wed, 16 Dec 2020, Vaittinen, Matti wrote:
> 
> > On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote:
> > > From: Khiem Nguyen <khiem.nguyen.xt@...esas.com>
> > > 
> > > The new PMIC BD9574MWF inherits features from BD9571MWV.
> > > Add the support of new PMIC to existing bd9571mwv driver.
> > > 
> > > Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@...esas.com>
> > > [shimoda: rebase and refactor]
> > > Signed-off-by: Yoshihiro Shimoda <
> > > yoshihiro.shimoda.uh@...esas.com>
> > 
> > Reviewed-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> > 
> > > ---
> > >  drivers/mfd/bd9571mwv.c       | 86
> > > ++++++++++++++++++++++++++++++++++++++++++-
> > >  include/linux/mfd/bd9571mwv.h | 18 +++++++--
> > >  2 files changed, 99 insertions(+), 5 deletions(-)
> 
> ... and please snip long replies.
> 
> Scrolling down past lots of un-reviewed code and/or past the end of
> the last review comment is a waste of people's time.  Thanks.
> 
Hm. Right. I thought that leaving whole patch there when just adding
ack or reviewed-by gives full information as to which exact patch
version was reviewed. But I admit scrolling can be annoying - besides,
the send/receive time in quote can probably be used to track the excat
version which was reviewed. So point taken. Thanks.

Best Regards
    Matti

Powered by blists - more mailing lists