lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Dec 2020 11:02:30 +0100 From: Pablo Neira Ayuso <pablo@...filter.org> To: Colin King <colin.king@...onical.com> Cc: Jozsef Kadlecsik <kadlec@...filter.org>, Florian Westphal <fw@...len.de>, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, netfilter-devel@...r.kernel.org, coreteam@...filter.org, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH][next] netfilter: nftables: fix incorrect increment of loop counter On Mon, Dec 14, 2020 at 11:40:15PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > The intention of the err_expr cleanup path is to iterate over the > allocated expr_array objects and free them, starting from i - 1 and > working down to the start of the array. Currently the loop counter > is being incremented instead of decremented and also the index i is > being used instead of k, repeatedly destroying the same expr_array > element. Fix this by decrementing k and using k as the index into > expr_array. Applied to nf.git, thanks.
Powered by blists - more mailing lists