linux-kernel - Re: linusw/devel bisection: baseline.bootrr.mediatek-mt8173-pinctrl-probed on mt8173-elm-hana

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e5e0251-9450-5c93-cd2e-c44779a72b0c@collabora.com>
Date:   Wed, 16 Dec 2020 10:10:04 +0000
From:   Guillaume Tucker <guillaume.tucker@...labora.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "kernelci-results@...ups.io" <kernelci-results@...ups.io>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Johan Hovold <johan@...nel.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Collabora Kernel ML <kernel@...labora.com>,
        Sean Wang <sean.wang@...nel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>
Subject: Re: linusw/devel bisection:
 baseline.bootrr.mediatek-mt8173-pinctrl-probed on mt8173-elm-hana

On 15/12/2020 12:20, Linus Walleij wrote:
> On Mon, Dec 14, 2020 at 11:28 PM Guillaume Tucker
> <guillaume.tucker@...labora.com> wrote:
> 
>> Please see the bisection report below about the pinctrl driver
>> failing to probe on the arm64 mt8173-elm-hana platform.
> 
> That's an excellent, helpful report which helps a lot!
> Thank you for doing this!

Thanks for the feedback!  Glad this helped.

>> This is the error message:
>>
>> [    0.051788] gpio gpiochip0: Detected name collision for GPIO name ''
>> [    0.051813] gpio gpiochip0: GPIO name collision on the same chip, this is not allowed, fix all lines on the chip to have unique names
>> [    0.051832] gpiochip_add_data_with_key: GPIOs 377..511 (1000b000.pinctrl) failed to register, -17
>> [    0.051946] mediatek-mt8173-pinctrl: probe of 1000b000.pinctrl failed with error -22
> 
> It seems we need to teach the core to ignore the name (empty string).

OK great, I see you've sent a patch for that.  I'll check if we
can confirm it fixes the issue (something I'd like to also
automate...).

Best wishes,
Guillaume