linux-kernel - Re: [PATCH 1/1] regulators: bd718x7: Add enable times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201216124814.GA4861@sirena.org.uk>
Date:   Wed, 16 Dec 2020 12:48:14 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Guido Günther <guido.gunther@...i.sm>
Cc:     "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        linux-power <linux-power@...rohmeurope.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "angus.ainslie@...i.sm" <angus.ainslie@...i.sm>
Subject: Re: [PATCH 1/1] regulators: bd718x7: Add enable times

On Wed, Dec 16, 2020 at 01:41:33PM +0100, Guido Günther wrote:
> On Wed, Dec 16, 2020 at 12:29:20PM +0000, Vaittinen, Matti wrote:

> > > +			.enable_time = 144,

> > Where are these values obtained from? I have a feeling they might be
> > board / load specific. If this is the case - can the "regulator-enable-
> > ramp-delay" from device-tree be used instead to avoid hard-coding board
> > specific values in the driver? Although, sane defaults would probably
> > not be a bad idea - if I read code correctly then the constrains from
> > DT can be used to override these values.

> They're the 'typical values' from the data sheet and it's basically all
> about setting a default for "regulator-enable-ramp-delay" to avoid
> having every board do the same. If that's not the right thing todo let
> me know and i add these to each of our boards (which is where i
> basically started from but then figured that this would be busywork
> and every board would hit that problem).

If it's a DCDC they're *probably* generic values rather than board
specific, they tend to be more predictable as they're regulating much
more actively than LDOs.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)