linux-kernel - Re: static_branch_enable() does not work from a _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201216132312.GA3021@hirez.programming.kicks-ass.net>
Date:   Wed, 16 Dec 2020 14:23:12 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Jessica Yu <jeyu@...nel.org>
Cc:     Dexuan Cui <decui@...rosoft.com>, Ingo Molnar <mingo@...nel.org>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>
Subject: Re: static_branch_enable() does not work from a __init function?

On Wed, Dec 16, 2020 at 02:10:16PM +0100, Jessica Yu wrote:
> +++ Peter Zijlstra [16/12/20 13:47 +0100]:

> > Only because we're having .init=false, incorrectly. See the other email.
> 
> Ah yeah, you're right. I also misread the intention of the if
> conditional :/ If we're currently running an init function it's fine,
> but after that it will be unsafe.

Exactly, seeing how it'll end up being freed and such ;-)

> Btw, your patch seems to work for me, using the test module provided
> by Dexuan.

Ah, excellent. I couldn't be bothered to figure out how to build a
module ;-)

I'll add your Tested-by and go queue it for /urgent I suppose.