linux-kernel - Re: [PATCH v4 1/3] scsi: ufs: Protect some contexts from unexpected clock scaling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f91342a001ef00f3b311952515dfb17747b7148.camel@gmail.com>
Date:   Wed, 16 Dec 2020 14:31:04 +0100
From:   Bean Huo <huobean@...il.com>
To:     Can Guo <cang@...eaurora.org>, asutoshd@...eaurora.org,
        nguyenb@...eaurora.org, hongwus@...eaurora.org,
        rnayak@...eaurora.org, linux-scsi@...r.kernel.org,
        kernel-team@...roid.com, saravanak@...gle.com, salyzyn@...gle.com
Cc:     Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Stanley Chu <stanley.chu@...iatek.com>,
        Bean Huo <beanhuo@...ron.com>,
        Bart Van Assche <bvanassche@....org>,
        Satya Tangirala <satyat@...gle.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/3] scsi: ufs: Protect some contexts from unexpected
 clock scaling

On Sun, 2020-12-13 at 08:31 -0800, Can Guo wrote:
> In contexts like suspend, shutdown and error handling, we need to
> suspend
> devfreq to make sure these contexts won't be disturbed by clock
> scaling.
> However, suspending devfreq is not enough since users can still
> trigger a
> clock scaling by manipulating the sysfs node clkscale_enable and
> devfreq
> sysfs nodes like min/max_freq and governor. Add one more flag in
> struct
> clk_scaling such that these contexts can prevent clock scaling from
> being
> invoked through above sysfs nodes.
> 
> Signed-off-by: Can Guo <cang@...eaurora.org>
looks good to me.

Reviewed-by: Bean Huo <beanhuo@...ron.com>