linux-kernel - Re: [BUG] perf probe can't remove probes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201216135929.GA294100@kernel.org>
Date:   Wed, 16 Dec 2020 10:59:29 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Clark Williams <williams@...hat.com>,
        linux-perf-users@...r.kernel.org
Subject: Re: [BUG] perf probe can't remove probes

Em Wed, Dec 16, 2020 at 09:16:40AM +0900, Masami Hiramatsu escreveu:
> On Thu, 26 Nov 2020 14:26:03 -0300
 Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> > Em Thu, Nov 26, 2020 at 09:21:25AM +0900, Masami Hiramatsu escreveu:
> > > On Wed, 25 Nov 2020 14:27:55 -0300 Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> > > As you can see, "-D" is showing definition. Not delete. (*)
> > > Delete is "-d" or "--del".

> > Yeah, I was in a hurry and looked at just the first line right after the
> > command, didn't want to forget reporting it so sent the "bug" report,
> > d0h, sorry about the noise, using -d or --del works.

> > But having both -d and -D, in retrospect, wasn't such a good idea :-\
> 
> Sorry for confusing :(
 
> Hmm, would we better to remove -D and keep only --definition?
> But it is already there, I think we should keep this option
> for backward compatibility.

Nah, since we have it there, lets take this just as a lesson and in the
future use single letter options just for core functionality, leaving
things like --definition to be just a long option.

We can't change it now :-)

- Arnaldo