lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Dec 2020 16:32:48 +0100 From: Andrew Lunn <andrew@...n.ch> To: Vladimir Oltean <vladimir.oltean@....com> Cc: Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, bridge@...ts.linux-foundation.org, Roopa Prabhu <roopa@...dia.com>, Nikolay Aleksandrov <nikolay@...dia.com>, "David S. Miller" <davem@...emloft.net>, DENG Qingfang <dqfext@...il.com>, Tobias Waldekranz <tobias@...dekranz.com>, Marek Behun <marek.behun@....cz>, Russell King - ARM Linux admin <linux@...linux.org.uk>, Alexandra Winter <wintera@...ux.ibm.com>, Jiri Pirko <jiri@...nulli.us>, Ido Schimmel <idosch@...sch.org>, Claudiu Manoil <claudiu.manoil@....com>, UNGLinuxDriver@...rochip.com Subject: Re: [PATCH v3 net-next 2/7] net: dsa: be louder when a non-legacy FDB operation fails On Sun, Dec 13, 2020 at 04:07:05PM +0200, Vladimir Oltean wrote: > The dev_close() call was added in commit c9eb3e0f8701 ("net: dsa: Add > support for learning FDB through notification") "to indicate inconsistent > situation" when we could not delete an FDB entry from the port. > > bridge fdb del d8:58:d7:00:ca:6d dev swp0 self master > > It is a bit drastic and at the same time not helpful if the above fails > to only print with netdev_dbg log level, but on the other hand to bring > the interface down. > > So increase the verbosity of the error message, and drop dev_close(). > > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists