lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Dec 2020 17:04:47 +0100 From: Andrew Lunn <andrew@...n.ch> To: Divya Koppera <Divya.Koppera@...rochip.com> Cc: hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net, kuba@...nel.org, marex@...x.de, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, UNGLinuxDriver@...rochip.com Subject: Re: [PATCH v3 net-next 1/2] net: phy: mchp: Add interrupt support for Link up and Link down to LAN8814 phy > +static irqreturn_t lan8814_handle_interrupt(struct phy_device *phydev) > +{ > + int irq_status; > + > + irq_status = phy_read(phydev, LAN8814_INTS); > + if (irq_status < 0) > + return IRQ_NONE; > + > + if (irq_status & LAN8814_INTS_ALL) > + phy_mac_interrupt(phydev); This is a PHY driver, so it should not be using the MAC API call. Please change to phy_trigger_machine(phydev); Andrew
Powered by blists - more mailing lists