linux-kernel - Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hsg85n2km.wl-tiwai@suse.de>
Date:   Wed, 16 Dec 2020 17:22:17 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     tiwai@...e.com, Jaroslav Kysela <perex@...ex.cz>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Alex Deucher <alexander.deucher@....com>,
        Mike Rapoport <rppt@...nel.org>,
        "moderated list:SOUND" <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

On Wed, 16 Dec 2020 17:07:45 +0100,
Kai-Heng Feng wrote:
> 
> On Wed, Dec 16, 2020 at 11:58 PM Takashi Iwai <tiwai@...e.de> wrote:
> >
> > On Wed, 16 Dec 2020 16:50:20 +0100,
> > Kai-Heng Feng wrote:
> > >
> > > On Wed, Dec 16, 2020 at 11:41 PM Takashi Iwai <tiwai@...e.de> wrote:
> > > >
> > > > On Wed, 16 Dec 2020 13:47:24 +0100,
> > > > Kai-Heng Feng wrote:
> > > > >
> > > > > Similar to commit 9479e75fca37 ("ALSA: hda: Keep the controller
> > > > > initialization even if no codecs found"), when codec probe fails, it
> > > > > doesn't enable runtime suspend, and can prevent graphics card from
> > > > > getting powered down:
> > > > > [    4.280991] snd_hda_intel 0000:01:00.1: no codecs initialized
> > > > >
> > > > > $ cat /sys/bus/pci/devices/0000:01:00.1/power/runtime_status
> > > > > active
> > > > >
> > > > > So mark there's no codec and continue probing to let runtime PM to work.
> > > > >
> > > > > BugLink: https://bugs.launchpad.net/bugs/1907212
> > > > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> > > >
> > > > Hm, but if the probe fails, doesn't it mean something really wrong?
> > > > IOW, how does this situation happen?
> > >
> > > The HDA controller is forcely created by quirk_nvidia_hda(). So
> > > probably there's really not an HDA controller.
> >
> > I still don't understand how non-zero codec_mask is passed.
> > The non-zero codec_mask means that BIOS or whatever believes that
> > HD-audio codecs are present and let HD-audio controller reporting the
> > presence.  What error did you get at probing?
> 
> [    4.280991] snd_hda_intel 0000:01:00.1: no codecs initialized
> Full dmesg here:
> https://launchpadlibrarian.net/510351476/dmesg.log

The actual problems are shown before that line.

[    4.178848] pci 0000:01:00.1: can't change power state from D3cold to D0 (config space inaccessible)
[    4.179502] snd_hda_intel 0000:01:00.1: can't change power state from D3cold to D0 (config space inaccessible)
[    4.179511] snd_hda_intel 0000:01:00.1: can't change power state from D3hot to D0 (config space inaccessible)
....
[    4.280571] hdaudio hdaudioC1D0: no AFG or MFG node found
[    4.280633] hdaudio hdaudioC1D1: no AFG or MFG node found
[    4.280685] hdaudio hdaudioC1D2: no AFG or MFG node found
[    4.280736] hdaudio hdaudioC1D3: no AFG or MFG node found
[    4.280788] hdaudio hdaudioC1D4: no AFG or MFG node found
[    4.280839] hdaudio hdaudioC1D5: no AFG or MFG node found
[    4.280892] hdaudio hdaudioC1D6: no AFG or MFG node found
[    4.280943] hdaudio hdaudioC1D7: no AFG or MFG node found

Could you check the codec_mask value read in
sound/hda/hdac_controller.c?  I guess it reads 0xff.

If that's the case, it can be corrected by the patch below.
But, we should check the cause of the first error (inaccessible config
space) in anyway; this must be the primary reason of the whole chain
of errors.

> > > > The usual no-codec state is for the devices that have a bogus HD-audio
> > > > bus remaining while codecs aren't hooked or disabled by BIOS.  For
> > > > that, it makes to leave the controller driver and let it idle.  But if
> > > > you get really an error, it's something to fix there, not to just
> > > > ignore in general.
> > >
> > > The best approach I can think of is to make current two steps probe
> > > into one. So when probe fails, the driver won't bind to the device.
> > > What's the reason behind the two steps approach?
> >
> > It's a sort of must, as the module loading is involved with binding
> > with the codecs, as well as (optionally) request_firmware()
> > invocation.
> 
> Ok. I also tried to use device_release_driver(), but azx_remove()
> calls "cancel_work_sync(&hda->probe_work)" so there will be a
> deadlock.

You can't do that.


Takashi

---
--- a/sound/hda/hdac_controller.c
+++ b/sound/hda/hdac_controller.c
@@ -449,6 +449,10 @@ int snd_hdac_bus_reset_link(struct hdac_bus *bus, bool full_reset)
 	if (!bus->codec_mask) {
 		bus->codec_mask = snd_hdac_chip_readw(bus, STATESTS);
 		dev_dbg(bus->dev, "codec_mask = 0x%lx\n", bus->codec_mask);
+		if (bus->codec_mask == 0xff) {
+			dev_err(bus->dev, "failed to read STATESTS register\n");
+			bus->codec_mask = 0;
+		}
 	}
 
 	return 0;