linux-kernel - Re: [PATCH V10 2/5] fuse: Passthrough initialization and release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <X9o77i1T4PDgm4q4@google.com>
Date:   Wed, 16 Dec 2020 16:55:10 +0000
From:   Alessio Balsini <balsini@...roid.com>
To:     "wu-yan@....com" <wu-yan@....com>
Cc:     balsini@...roid.com, akailash@...gle.com, amir73il@...il.com,
        axboe@...nel.dk, duostefano93@...il.com, dvander@...gle.com,
        fuse-devel@...ts.sourceforge.net, gscrivan@...hat.com,
        jannh@...gle.com, kernel-team@...roid.com,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        maco@...roid.com, miklos@...redi.hu, palmer@...belt.com,
        paullawrence@...gle.com, trapexit@...wn.link, zezeozue@...gle.com
Subject: Re: [PATCH V10 2/5] fuse: Passthrough initialization and release

On Wed, Dec 16, 2020 at 09:32:51PM +0800, wu-yan@....com wrote:
> Hi Alessio,
> 
> It may cause file reference counter leak in fuse_passthrough_open. If the
> passthrough_filp
> 
> not implement read_iter/write_iter or passthrough struct allocated failed,
> the reference counter get in fget(pro->fd) not released and cause leak.
> 
> Cheers,
> 
> yanwu
> 


Hi yanwu,

Nice catch, this bug was introduced in v10 and will be fixed in the next
patch set.

Cheers,
Alessio