linux-kernel - Re: [PATCH net-next] seg6: fix the max number of supported SRv6 behavior attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201215174704.545462ff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 15 Dec 2020 17:47:04 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrea Mayer <andrea.mayer@...roma2.it>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Lebrun <david.lebrun@...ouvain.be>,
        Mathieu Xhonneux <m.xhonneux@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Colin Ian King <colin.king@...onical.com>,
        Stefano Salsano <stefano.salsano@...roma2.it>,
        Paolo Lungaroni <paolo.lungaroni@...t.it>,
        Ahmed Abdelsalam <ahabdels.dev@...il.com>
Subject: Re: [PATCH net-next] seg6: fix the max number of supported SRv6
 behavior attributes

On Wed, 16 Dec 2020 02:08:34 +0100 Andrea Mayer wrote:
> I agree with this approach. Only for the sake of clarity I would prefer to
> define the macro SEG6_LOCAL_MAX_SUPP as follows:
> 
> in seg6_local.c:
>  [...]
> 
>  /* max total number of supported SRv6 behavior attributes */
>  #define SEG6_LOCAL_MAX_SUPP 32
> 
>  int __init seg6_local_init(void)
>  {
>     BUILD_BUG_ON(SEG6_LOCAL_MAX + 1 > SEG6_LOCAL_MAX_SUPP);
>     [...]
>  }
> 
> 
> Due to the changes, I will submit a new patch (v1) with a more appropriate
> subject. The title of the new patch will most likely be:
> 
>  seg6: fool-proof the processing of SRv6 behavior attributes

SGTM, thanks!