linux-kernel - Re: [PATCH net-next 1/4] enetc: drop unneeded indirection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201216192016.q5klhv2mdv6yg73a@skbuf>
Date:   Wed, 16 Dec 2020 19:20:17 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Michael Walle <michael@...le.cc>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Claudiu Manoil <claudiu.manoil@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexandru Marginean <alexandru.marginean@....com>
Subject: Re: [PATCH net-next 1/4] enetc: drop unneeded indirection

On Tue, Dec 15, 2020 at 10:21:57PM +0100, Michael Walle wrote:
> Before commit 6517798dd343 ("enetc: Make MDIO accessors more generic and
> export to include/linux/fsl") these macros actually had some benefits.
> But after the commit it just makes the code hard to read. Drop the macro
> indirections.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>