lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Dec 2020 21:16:54 +0100 From: Bean Huo <huobean@...il.com> To: Adrian Hunter <adrian.hunter@...el.com>, "Martin K . Petersen" <martin.petersen@...cle.com>, "James E . J . Bottomley" <jejb@...ux.ibm.com> Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>, Avri Altman <avri.altman@....com>, Can Guo <cang@...eaurora.org>, Stanley Chu <stanley.chu@...iatek.com> Subject: Re: [PATCH V2] scsi: ufs-debugfs: Add error counters On Wed, 2020-12-16 at 20:51 +0200, Adrian Hunter wrote: > ufshcd_variant_hba_exit(hba); > ufshcd_setup_vreg(hba, false); > ufshcd_suspend_clkscaling(hba); > @@ -9436,6 +9441,20 @@ int ufshcd_init(struct ufs_hba *hba, void > __iomem *mmio_base, unsigned int irq) > } > EXPORT_SYMBOL_GPL(ufshcd_init); > > +static int __init ufshcd_core_init(void) > +{ > + ufs_debugfs_init(); > + return 0; > +} > + > +static void __exit ufshcd_core_exit(void) > +{ > + ufs_debugfs_exit(); > +} Hi, Adrian The purpose of patch is acceptable, but I don't know why you choose using ufshcd_core_* here. Also. I don't know if module_init() is a proper way here. thanks, Bean > > n > + > +module_init(ufshcd_core_init); > +module_exit(ufshcd_core_exit)
Powered by blists - more mailing lists