linux-kernel - Re: [PATCH] atm: ambassador: remove h from printk format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201216164510.770454d8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 16 Dec 2020 16:45:10 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     trix@...hat.com
Cc:     3chas3@...il.com, linux-atm-general@...ts.sourceforge.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: ambassador: remove h from printk format specifier

On Tue, 15 Dec 2020 06:22:28 -0800 trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> See Documentation/core-api/printk-formats.rst.
> h should no longer be used in the format specifier for printk.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

That's for new code I assume?

What's the harm in leaving this ancient code be?

> diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
> index c039b8a4fefe..6b0fff8c0141 100644
> --- a/drivers/atm/ambassador.c
> +++ b/drivers/atm/ambassador.c
> @@ -2169,7 +2169,7 @@ static void setup_pci_dev(struct pci_dev *pci_dev)
>  		pci_lat = (lat < MIN_PCI_LATENCY) ? MIN_PCI_LATENCY : lat;
>  
>  	if (lat != pci_lat) {
> -		PRINTK (KERN_INFO, "Changing PCI latency timer from %hu to %hu",
> +		PRINTK (KERN_INFO, "Changing PCI latency timer from %u to %u",
>  			lat, pci_lat);
>  		pci_write_config_byte(pci_dev, PCI_LATENCY_TIMER, pci_lat);
>  	}
> @@ -2300,7 +2300,7 @@ static void __init amb_check_args (void) {
>    unsigned int max_rx_size;
>    
>  #ifdef DEBUG_AMBASSADOR
> -  PRINTK (KERN_NOTICE, "debug bitmap is %hx", debug &= DBG_MASK);
> +  PRINTK (KERN_NOTICE, "debug bitmap is %x", debug &= DBG_MASK);
>  #else
>    if (debug)
>      PRINTK (KERN_NOTICE, "no debugging support");