linux-kernel - Re: [PATCH] fs: ext4: remove unnecessary wbc parameter from ext4_bio_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X9r59yLN+NABG0p4@mit.edu>
Date:   Thu, 17 Dec 2020 01:25:59 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     chenlei0x@...il.com
Cc:     adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, Lei Chen <lennychen@...cent.com>
Subject: Re: [PATCH] fs: ext4: remove unnecessary wbc parameter from
 ext4_bio_write_page

On Fri, Dec 11, 2020 at 02:54:24PM +0800, chenlei0x@...il.com wrote:
> From: Lei Chen <lennychen@...cent.com>
> 
> ext4_bio_write_page does not need wbc parameter, since its parameter
> io contains the io_wbc field. The io::io_wbc is initialized by
> ext4_io_submit_init which is called in ext4_writepages and
> ext4_writepage functions prior to ext4_bio_write_page.
> Therefor, when ext4_bio_write_page is called, wbc info
> has already been included in io parameter.
> 
> Signed-off-by: Lei Chen <lennychen@...cent.com>

Thanks, applied.

					- Ted