linux-kernel - Re: [PATCH wireless -next] rtw88: Delete useless kfree code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1608166499.2560.0.camel@realtek.com>
Date:   Thu, 17 Dec 2020 00:55:12 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tony0620emma@...il.com" <tony0620emma@...il.com>,
        "zhengyongjun3@...wei.com" <zhengyongjun3@...wei.com>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH wireless -next] rtw88: Delete useless kfree code

On Wed, 2020-12-16 at 13:04 +0000, Zheng Yongjun wrote:
> The parameter of kfree function is NULL, so kfree code is useless, delete it.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

> ---
>  drivers/net/wireless/realtek/rtw88/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/main.c
> b/drivers/net/wireless/realtek/rtw88/main.c
> index 565efd880624..15568cd670a3 100644
> --- a/drivers/net/wireless/realtek/rtw88/main.c
> +++ b/drivers/net/wireless/realtek/rtw88/main.c
> @@ -1249,7 +1249,6 @@ static void rtw_set_supported_band(struct ieee80211_hw
> *hw,
>  
>  err_out:
>  	rtw_err(rtwdev, "failed to set supported band\n");
> -	kfree(sband);
>  }
>  
>  static void rtw_unset_supported_band(struct ieee80211_hw *hw,