lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Dec 2020 00:58:26 -0800 From: Stephen Boyd <sboyd@...nel.org> To: Sergio Paracuellos <sergio.paracuellos@...il.com>, mturquette@...libre.com Cc: robh+dt@...nel.org, john@...ozen.org, tsbogend@...ha.franken.de, gregkh@...uxfoundation.org, gch981213@...il.com, hackpascal@...il.com, linux-clk@...r.kernel.org, evicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org, devel@...verdev.osuosl.org, neil@...wn.name Subject: Re: [PATCH v4 2/6] dt: bindings: add mt7621-clk device tree binding documentation Quoting Sergio Paracuellos (2020-11-22 01:55:52) > Adds device tree binding documentation for clocks in the > MT7621 SOC. > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@...il.com> > --- > .../bindings/clock/mediatek,mt7621-clk.yaml | 67 +++++++++++++++++++ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt7621-clk.yaml > Rob? > diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt7621-clk.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt7621-clk.yaml > new file mode 100644 > index 000000000000..6aca4c1a4a46 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/mediatek,mt7621-clk.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/mediatek,mt7621-clk.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MT7621 Clock Device Tree Bindings > + > +maintainers: > + - Sergio Paracuellos <sergio.paracuellos@...il.com> > + > +description: | > + The MT7621 has a PLL controller from where the cpu clock is provided > + as well as derived clocks for the bus and the peripherals. It also > + can gate SoC device clocks. > + > + Each clock is assigned an identifier and client nodes use this identifier > + to specify the clock which they consume. > + > + All these identifiers could be found in: > + [1]: <include/dt-bindings/clock/mt7621-clk.h>. > + > + The mt7621 clock node should be the child of a syscon node with the > + required property: > + > + - compatible: Should be one of the following: > + "mediatek,mt7621-sysc", "syscon" > + > + Refer to the bindings described in > + Documentation/devicetree/bindings/mfd/syscon.yaml > + > +properties: > + compatible: > + const: mediatek,mt7621-clk > + > + "#clock-cells": > + description: > + The first cell indicates the clock gate number, see [1] for available > + clocks. > + const: 1 > + > + clock-output-names: > + maxItems: 8 > + > +required: > + - compatible > + - '#clock-cells' > + - clock-output-names Why is clock-output-names required? Hopefully it is not required. > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/mt7621-clk.h> > + > + sysc: sysc@0 { syscon@0? I don't think sysc is a standard node name. > + compatible = "mediatek,mt7621-sysc", "syscon"; > + reg = <0x0 0x100>; > + > + pll { clock-controller? Why can't the parent device be the clk provider and have #clock-cells? > + compatible = "mediatek,mt7621-clk"; > + #clock-cells = <1>; > + clock-output-names = "xtal", "cpu", "bus", > + "50m", "125m", "150m", > + "250m", "270m"; > + }; > + };
Powered by blists - more mailing lists