linux-kernel - Re: [PATCH -next] ti/fapll: Delete useless kfree code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <160819854054.1580929.11774494737699871550@swboyd.mtv.corp.google.com>
Date:   Thu, 17 Dec 2020 01:49:00 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, mturquette@...libre.com,
        t-kristo@...com
Cc:     Zheng Yongjun <zhengyongjun3@...wei.com>
Subject: Re: [PATCH -next] ti/fapll: Delete useless kfree code

Quoting Zheng Yongjun (2020-12-16 05:05:34)
> The parameter of kfree function is NULL, so kfree code is useless, delete it.

Not always though. Sometimes it is non-NULL and this code avoids a goto.

> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
>  drivers/clk/ti/fapll.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c
> index 95e36ba64acc..a61d69159e9a 100644
> --- a/drivers/clk/ti/fapll.c
> +++ b/drivers/clk/ti/fapll.c
> @@ -523,7 +523,6 @@ static struct clk * __init ti_fapll_synth_setup(struct fapll_data *fd,
>         return clk_register(NULL, &synth->hw);
>  
>  free:
> -       kfree(synth);
>         kfree(init);
>  
>         return ERR_PTR(-ENOMEM);