linux-kernel - [PATCH] writeback: add warning messages for not registered bdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201217112801.22421-1-zhang.yanjuna@h3c.com>
Date:   Thu, 17 Dec 2020 19:28:01 +0800
From:   Yanjun Zhang <zhang.yanjuna@....com>
To:     <viro@...iv.linux.org.uk>
CC:     <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Yanjun Zhang <zhang.yanjuna@....com>
Subject: [PATCH] writeback: add warning messages for not registered bdi

The device name is only printed for the warning case, that bdi is not
registered detected by the function __mark_inode_dirty. Besides, the
device name returned by bdi_dev_name may be "(unknown)" in some cases.

This patch add printed messages about the inode and super block. Once
trigging this warning, we could make more direct analysis.

Signed-off-by: Yanjun Zhang <zhang.yanjuna@....com>
---
 fs/fs-writeback.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index e6005c78b..825160cf4 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -2323,7 +2323,8 @@ void __mark_inode_dirty(struct inode *inode, int flags)
 
 			WARN((wb->bdi->capabilities & BDI_CAP_WRITEBACK) &&
 			     !test_bit(WB_registered, &wb->state),
-			     "bdi-%s not registered\n", bdi_dev_name(wb->bdi));
+			     "bdi-%s not registered, dirtied inode %lu on %s\n",
+			     bdi_dev_name(wb->bdi), inode->i_ino, sb->s_id);
 
 			inode->dirtied_when = jiffies;
 			if (dirtytime)
-- 
2.17.1