linux-kernel - Re: [PATCH 18/25] btrfs: Use readahead_batch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201217134253.GE15600@casper.infradead.org>
Date:   Thu, 17 Dec 2020 13:42:53 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     John Hubbard <jhubbard@...dia.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 18/25] btrfs: Use readahead_batch_length

On Thu, Dec 17, 2020 at 12:12:46PM +0000, Matthew Wilcox wrote:
> ehh ... probably an off-by-one.  Does subtracting 1 from contig_end fix it?
> I'll spool up a test VM shortly and try it out.

Yes, this fixed it:

-               u64 contig_end = contig_start + readahead_batch_length(rac);
+               u64 contig_end = contig_start + readahead_batch_length(rac) - 1;