linux-kernel - Re: [PATCH] mm/filemap: Fix warning: no previous prototype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201217022306.GB15600@casper.infradead.org>
Date:   Thu, 17 Dec 2020 02:23:06 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Xiangyang Yu <yuxiangyang4@...wei.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/filemap: Fix warning: no previous prototype

On Thu, Dec 17, 2020 at 10:03:11AM +0800, Xiangyang Yu wrote:
> Fixed the warning when building with warnings enabled (W=1),
> This function is only used in filemap.c, so mark this function
> with 'static'.

Good grief, no.  Look at the git history before proposing a patch.