linux-kernel - Re: [PATCH] selftests/vDSO: fix -Wformat warning in vdso_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3bb8366-f1ab-31bc-fd6c-7e7cbfeb72a1@linuxfoundation.org>
Date:   Thu, 17 Dec 2020 11:29:52 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Tobias Klauser <tklauser@...tanz.ch>, Shuah Khan <shuah@...nel.org>
Cc:     Vincenzo Frascino <vincenzo.frascino@....com>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/vDSO: fix -Wformat warning in
 vdso_test_correctness

On 12/17/20 9:32 AM, Tobias Klauser wrote:
> Fix the following -Wformat warnings in vdso_test_correctness.c:
> 
> vdso_test_correctness.c: In function ‘test_one_clock_gettime64’:
> vdso_test_correctness.c:352:21: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘long long int’ [-Wformat=]
>    352 |  printf("\t%llu.%09ld %llu.%09ld %llu.%09ld\n",
>        |                 ~~~~^
>        |                     |
>        |                     long int
>        |                 %09lld
>    353 |         (unsigned long long)start.tv_sec, start.tv_nsec,
>        |                                           ~~~~~~~~~~~~~
>        |                                                |
>        |                                                long long int
> vdso_test_correctness.c:352:32: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘long long int’ [-Wformat=]
>    352 |  printf("\t%llu.%09ld %llu.%09ld %llu.%09ld\n",
>        |                            ~~~~^
>        |                                |
>        |                                long int
>        |                            %09lld
>    353 |         (unsigned long long)start.tv_sec, start.tv_nsec,
>    354 |         (unsigned long long)vdso.tv_sec, vdso.tv_nsec,
>        |                                          ~~~~~~~~~~~~
>        |                                              |
>        |                                              long long int
> vdso_test_correctness.c:352:43: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 7 has type ‘long long int’ [-Wformat=]
> 
> The tv_sec member of __kernel_timespec is long long, both in
> uapi/linux/time_types.h and locally in vdso_test_correctness.c.
> 
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
> ---
>   tools/testing/selftests/vDSO/vdso_test_correctness.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/vDSO/vdso_test_correctness.c b/tools/testing/selftests/vDSO/vdso_test_correctness.c
> index 5029ef9b228c..c4aea794725a 100644
> --- a/tools/testing/selftests/vDSO/vdso_test_correctness.c
> +++ b/tools/testing/selftests/vDSO/vdso_test_correctness.c
> @@ -349,7 +349,7 @@ static void test_one_clock_gettime64(int clock, const char *name)
>   		return;
>   	}
>   
> -	printf("\t%llu.%09ld %llu.%09ld %llu.%09ld\n",
> +	printf("\t%llu.%09lld %llu.%09lld %llu.%09lld\n",
>   	Thanks for the patch.

Thanks for the patch.

Applied to linux-kselftest next

thanks,
-- Shuah