linux-kernel - Re: [net-next PATCH v2 08/14] net: mdiobus: Introduce fwnode_mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201218054044.GB14594@lsv03152.swis.in-blr01.nxp.com>
Date:   Fri, 18 Dec 2020 11:10:44 +0530
From:   Calvin Johnson <calvin.johnson@....nxp.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Grant Likely <grant.likely@....com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Jeremy Linton <jeremy.linton@....com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Russell King - ARM Linux admin <linux@...linux.org.uk>,
        Cristi Sovaiala <cristian.sovaiala@....com>,
        Florin Laurentiu Chiculita <florinlaurentiu.chiculita@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Madalin Bucur <madalin.bucur@....nxp.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Pieter Jansen Van Vuuren <pieter.jansenvv@...boosystems.io>,
        Jon <jon@...id-run.com>, "linux.cj" <linux.cj@...il.com>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        Diana Madalina Craciun <diana.craciun@....com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        netdev <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [net-next PATCH v2 08/14] net: mdiobus: Introduce
 fwnode_mdiobus_register()

On Tue, Dec 15, 2020 at 07:53:26PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson
> <calvin.johnson@....nxp.com> wrote:
> >
> > Introduce fwnode_mdiobus_register() to register PHYs on the  mdiobus.
> > If the fwnode is DT node, then call of_mdiobus_register().
> > If it is an ACPI node, then:
> >         - disable auto probing of mdiobus
> >         - register mdiobus
> >         - save fwnode to mdio structure
> >         - loop over child nodes & register a phy_device for each PHY
> 
> ...
> 
> > +/**
> > + * fwnode_mdiobus_register - Register mii_bus and create PHYs from fwnode
> > + * @mdio: pointer to mii_bus structure
> > + * @fwnode: pointer to fwnode of MDIO bus.
> > + *
> > + * This function registers the mii_bus structure and registers a phy_device
> > + * for each child node of @fwnode.
> > + */
> > +int fwnode_mdiobus_register(struct mii_bus *mdio, struct fwnode_handle *fwnode)
> > +{
> > +       struct fwnode_handle *child;
> > +       unsigned long long addr;
> > +       acpi_status status;
> > +       int ret;
> > +
> > +       if (is_of_node(fwnode)) {
> > +               return of_mdiobus_register(mdio, to_of_node(fwnode));
> > +       } else if (is_acpi_node(fwnode)) {
> 
> I would rather see this as simple as
> 
>      if (is_of_node(fwnode))
>                return of_mdiobus_register(mdio, to_of_node(fwnode));
>      if (is_acpi_node(fwnode))
>                return acpi_mdiobus_register(mdio, fwnode);
> 
> where the latter one is defined somewhere in drivers/acpi/.
Makes sense. I'll do it. But I think it will be better to place
acpi_mdiobus_register() here itself in the network subsystem, maybe
/drivers/net/mdio/acpi_mdio.c.
> 
> > +               /* Mask out all PHYs from auto probing. */
> > +               mdio->phy_mask = ~0;
> > +               ret = mdiobus_register(mdio);
> > +               if (ret)
> > +                       return ret;
> > +
> > +               mdio->dev.fwnode = fwnode;
> > +       /* Loop over the child nodes and register a phy_device for each PHY */
> > +               fwnode_for_each_child_node(fwnode, child) {
> 
> > +                       status = acpi_evaluate_integer(ACPI_HANDLE_FWNODE(child),
> > +                                                      "_ADR", NULL, &addr);
> > +                       if (ACPI_FAILURE(status)) {
> 
> Isn't it fwnode_get_id() now?
Yes. Will change it.
> 
> > +                               pr_debug("_ADR returned %d\n", status);
> > +                               continue;
> > +                       }
> 
> > +                       if (addr < 0 || addr >= PHY_MAX_ADDR)
> > +                               continue;
> 
> addr can't be less than 0.
Yes. will update in v3.
> 
> > +                       ret = fwnode_mdiobus_register_phy(mdio, child, addr);
> > +                       if (ret == -ENODEV)
> > +                               dev_err(&mdio->dev,
> > +                                       "MDIO device at address %lld is missing.\n",
> > +                                       addr);
> > +               }
> > +               return 0;
> > +       }
> > +       return -EINVAL;
> > +}
> 
> -- 
> With Best Regards,
> Andy Shevchenko